Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suppress type error for fallback def of OptionalRetry #1065

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 3, 2021

Introduced in #1032.

mypy balks at rebinding a typename in the fallback:

google/cloud/datastore_v1/services/datastore/client.py:38: error: Cannot assign multiple types to name "OptionalRetry" without an explicit "Type[...]" annotation

Since the object fallback is only for older versions of google-api-core, which needed to be ignored anyway, ignoring the reassignment is safe.

@tseaver tseaver requested a review from a team as a code owner November 3, 2021 14:56
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2021
@tseaver tseaver merged commit e47faa6 into master Nov 3, 2021
@tseaver tseaver deleted the 1032-fix-optional-retry-typing-moar branch November 3, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants