Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle required fields properly in query_params #1068

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

kbandes
Copy link
Contributor

@kbandes kbandes commented Nov 3, 2021

A required field with a default value was getting dropped from query_params in the transcoding logic. This fix ensures that required fields are included, regardless of value.

@kbandes kbandes requested a review from a team as a code owner November 3, 2021 20:43
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2021
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants