Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Sep 9, 2022

This PR fixes an issue where rpcs which do not have the google.api.http annotation are included in rest.py

@parthea parthea requested review from a team as code owners September 9, 2022 18:05
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 9, 2022
@parthea parthea requested a review from vam-google September 9, 2022 18:06
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming generated unit tests work

@parthea parthea merged commit c12a1c2 into main Sep 9, 2022
@parthea parthea deleted the rest-remove-grpc-only-methods branch September 9, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants