Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cred info to auth related errors #2115

Merged
merged 6 commits into from
Jan 9, 2025
Merged

feat: add cred info to auth related errors #2115

merged 6 commits into from
Jan 9, 2025

Conversation

arithmetic1728
Copy link
Contributor

@arithmetic1728 arithmetic1728 commented Aug 29, 2024

Adds cred info to error details for 401/403/404 errors. See go/python-auth-error-message-improvement.

Manually tested with KMS client: arithmetic1728/google-cloud-python#1

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Aug 29, 2024
@arithmetic1728 arithmetic1728 force-pushed the cred_info branch 2 times, most recently from 137ee25 to e909f85 Compare August 29, 2024 01:30
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Aug 29, 2024
@arithmetic1728 arithmetic1728 force-pushed the cred_info branch 2 times, most recently from 96a3067 to 87a0f75 Compare August 29, 2024 10:09
@arithmetic1728 arithmetic1728 removed the size: m Pull request size is medium. label Aug 29, 2024
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Aug 29, 2024
@arithmetic1728 arithmetic1728 marked this pull request as ready for review August 29, 2024 23:48
@arithmetic1728 arithmetic1728 requested a review from a team as a code owner August 29, 2024 23:48
@arithmetic1728 arithmetic1728 changed the title [Work in progress] feat: add cred info to auth related errors feat: add cred info to auth related errors Aug 29, 2024
@arithmetic1728 arithmetic1728 requested a review from ohmayr August 29, 2024 23:49
@arithmetic1728 arithmetic1728 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 29, 2024
@arithmetic1728 arithmetic1728 assigned ohmayr and unassigned vchudnov-g Aug 29, 2024
@arithmetic1728 arithmetic1728 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 11, 2024
@ohmayr ohmayr requested a review from vchudnov-g September 11, 2024 03:25
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor observations

@parthea parthea assigned ohmayr and unassigned ohmayr Sep 14, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 8, 2025
@parthea parthea merged commit a694ceb into main Jan 9, 2025
126 checks passed
@parthea parthea deleted the cred_info branch January 9, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants