feat: add async rest transport support in gapics #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohmayr
added
the
do not merge
|
I had to manually update the goldens after resolving merge conflicts. This PR can be merged once we do a release in the following order:
|
parthea
approved these changes
Sep 17, 2024
gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest_base.py.j2
Show resolved
Hide resolved
gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2
Outdated
Show resolved
Hide resolved
Co-authored-by: ohmayr <omairn@google.com>
ohmayr
removed
the
do not merge
ohmayr
changed the title
gkevinzheng
pushed a commit
that referenced
this pull request
Oct 22, 2024
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements experimental support for asynchronous rest transport in gapics.
Note: Changes should not be pushed directly to to
async-rest-support-in-gapics. Once the work is completed, this PR can be merged.Fixes: #2152