Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase mixin tests fail for Ads templates #2182

Open
parthea opened this issue Sep 20, 2024 · 0 comments
Open

Showcase mixin tests fail for Ads templates #2182

parthea opened this issue Sep 20, 2024 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@parthea
Copy link
Contributor

parthea commented Sep 20, 2024

See build log here where the mixin tests fail for Ads templates in PR #2175

See stack trace below

tests/system/test_mixins.py:75: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/tmp/tmpdpiecome/google/showcase/v1beta1/services/echo/client.py:1521: in get_location
    self._transport.get_location,
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <google.showcase.v1beta1.services.echo.transports.rest.EchoRestTransport object at 0x7f63c5f9bb50>

    @property
    def get_location(self,
    ) -> Callable[
        [locations_pb2.GetLocationRequest],
        Union[locations_pb2.Location, Awaitable[locations_pb2.Location]],
    ]:
>       raise NotImplementedError()
E       NotImplementedError

/tmp/tmpdpiecome/google/showcase/v1beta1/services/echo/transports/base.py:367: NotImplementedError
__________________________ test_list_locations[rest] ___________________________

echo = <google.showcase.v1beta1.services.echo.client.EchoClient object at 0x7f63c5fe3310>

    def test_list_locations(echo):
        response = echo.list_locations(
            {
>               "name": "projects/some_project",
            }
        )

tests/system/test_mixins.py:84: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/tmp/tmpdpiecome/google/showcase/v1beta1/services/echo/client.py:1572: in list_locations
    self._transport.list_locations,
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <google.showcase.v1beta1.services.echo.transports.rest.EchoRestTransport object at 0x7f63c5f9ea10>

    @property
    def list_locations(self,
    ) -> Callable[
        [locations_pb2.ListLocationsRequest],
        Union[locations_pb2.ListLocationsResponse, Awaitable[locations_pb2.ListLocationsResponse]],
    ]:
>       raise NotImplementedError()
E       NotImplementedError

/tmp/tmpdpiecome/google/showcase/v1beta1/services/echo/transports/base.py:375: NotImplementedError
@parthea parthea added the type: cleanup An internal cleanup or hygiene concern. label Sep 20, 2024
@vchudnov-g vchudnov-g removed their assignment Sep 25, 2024
@vchudnov-g vchudnov-g added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

2 participants