feat: add ability to remove unversioned modules #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchudnov-g
approved these changes
Feb 13, 2025
| @@ -145,6 +146,50 @@ def test_get_response_ignore_gapic_metadata(): | |||
| assert res.file == CodeGeneratorResponse().file | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("unversioned_package_disabled", (True, False)) | |||
| def test_get_response_ignore_unversioned_package(unversioned_package_disabled): | |||
| g = make_generator() | |||
There was a problem hiding this comment.
Please don't use one character variable names. I see the same construct is used in other tests, but I advocate not perpetuating the practice.
Suggested change
| g = make_generator() | |
| generator = make_generator() |
| service_yaml_config=service_config, | ||
| ) | ||
|
|
||
| with mock.patch.object(jinja2.FileSystemLoader, "list_templates") as lt: |
There was a problem hiding this comment.
I'd still suggest avoiding short names if possible, though these are two-character and used closed to the definition, which makes it more amenabel IMO.
Consider s/lt/lister/ and s/gt/getter/
product-auto-label
bot
added
size: l
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Googlers see go/gapic-default-imports