Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update GOOGLE_API_USE_MTLS values #449

Merged
merged 1 commit into from
Jun 10, 2020
Merged

fix: update GOOGLE_API_USE_MTLS values #449

merged 1 commit into from
Jun 10, 2020

Conversation

arithmetic1728
Copy link
Collaborator

@arithmetic1728 arithmetic1728 commented Jun 10, 2020

Go client uses lower case, so change the values to lower case.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 10, 2020
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #449 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #449   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1453      1453           
  Branches       300       300           
=========================================
  Hits          1453      1453           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaa6f36...c50568b. Read the comment docs.

@busunkim96
Copy link
Contributor

@software-dov Once this is merged, could you cut a release? I want to release a new version of the service directory with the fixes in #424

Thank you! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants