fix: generated unit tests live in the 'tests/gapic' subdir #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some GAPICs have a manual layer and corresponding handwritten unit tests. These handwritten surfaces are subject to linting, but the autogenerated portions of the surface should not be. Moving generated unit tests to their own subdirectory makes it easier to remove them from linting rules. implementation for googleapis#454
software-dov
requested review from
vchudnov-g,
busunkim96,
xiaozhenliu-gg5 and
arithmetic1728
googlebot
added
the
cla: yes
busunkim96
approved these changes
Jun 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1453 1453
Branches 300 300
=========================================
Hits 1453 1453 Continue to review full report at Codecov.
|
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some GAPICs have a manual layer and corresponding handwritten unit tests.
These handwritten surfaces are subject to linting, but the
autogenerated portions of the surface should not be.
Moving generated unit tests to their own subdirectory makes it easier
to remove them from linting rules.
implementation for #454