-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showcase tests hang indefinitely #491
Comments
Running into the same issue on my end. I think @crwilcox encountered this too. Trying to reproduce locally |
It's the async code in |
https://app.circleci.com/pipelines/github/googleapis/gapic-generator-python/326/workflows/4bcdf203-1433-4559-a5bb-1851fd2f5717/jobs/13183/steps @software-dov It looks like it ran and passed on the most recent commit to master. |
It looks like a new version of grpcio came out last week https://github.com/grpc/grpc/releases/tag/v1.30.0. pytest-asyncio also had a new release, but the changelog doesn't have anything that stands out to me |
@software-dov I can reproduce the error with HEAD. There could be a bug in |
The root cause is that the event loop got re-created between tests. This behavior was unexpected since the AsyncIO stack built upon the assumption that applications don't close the event loop in main thread. Unfortunately, the This is a known issue. I had an override (see code) to work around their official fixture, but the new change doesn't work with my fixture (see change). A temporary fix is available at #493. I will improve the gRPC AsyncIO stack to accommodate this case. Sorry for the trouble. |
Followup fix of the ephemeral-loop-deadlock issue in grpc/grpc#23377. |
The showcase session on recently opened PRs seems to hang #485 #470
Log
I see the same behavior with a local run on master so I'm not sure what the root cause is.
The text was updated successfully, but these errors were encountered: