Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firestore generation broken in versions >= 0.26.6 #521

Closed
busunkim96 opened this issue Jul 14, 2020 · 2 comments
Closed

Firestore generation broken in versions >= 0.26.6 #521

busunkim96 opened this issue Jul 14, 2020 · 2 comments
Assignees
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.

Comments

@busunkim96
Copy link
Contributor

The pagination fix in #517 seems to be the cause.

CC @crwilcox

Traceback (most recent call last):
  File "/usr/local/bin/protoc-gen-python_gapic", line 8, in <module>
    sys.exit(generate())
  File "/usr/local/lib/python3.7/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.7/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/gapic/cli/generate.py", line 58, in generate
    api_schema = api.API.build(req.proto_file, opts=opts, package=package)
  File "/usr/local/lib/python3.7/site-packages/gapic/schema/api.py", line 277, in build
    for name, proto in pre_protos.items()
  File "/usr/local/lib/python3.7/site-packages/gapic/schema/api.py", line 277, in <dictcomp>
    for name, proto in pre_protos.items()
  File "/usr/local/lib/python3.7/site-packages/gapic/schema/api.py", line 87, in build
    load_services=load_services
  File "/usr/local/lib/python3.7/site-packages/gapic/schema/api.py", line 511, in proto
    for k, v in naive.services.items()
  File "/usr/local/lib/python3.7/site-packages/gapic/schema/api.py", line 511, in <genexpr>
    for k, v in naive.services.items()
  File "/usr/local/lib/python3.7/site-packages/gapic/schema/wrappers.py", line 845, in __getattr__
    return getattr(self.service_pb, name)
AttributeError: names
--python_gapic_out: protoc-gen-python_gapic: Plugin failed with status code 1.
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jul 15, 2020
@software-dov software-dov added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed triage me I really want to be triaged. labels Jul 15, 2020
@software-dov
Copy link
Contributor

Reproduced and verified that reverting #517 fixes the crash

@software-dov
Copy link
Contributor

Fixed by #527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.
Projects
None yet
Development

No branches or pull requests

3 participants