Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore types for imports generated from 'google.api_core' #597

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 15, 2020

Closes #596.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2020
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #597 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #597   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1519      1519           
  Branches       309       309           
=========================================
  Hits          1519      1519           
Impacted Files Coverage Δ
gapic/schema/imp.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5279ef...742702c. Read the comment docs.

@software-dov software-dov merged commit 8440e09 into master Sep 15, 2020
@tseaver tseaver deleted the 596-ignore-types-for-api_core branch September 15, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LRO imports need '# type: ignore'
2 participants