feat: add support for common resource paths #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
software-dov
requested review from
lukesneeringer,
crwilcox,
vchudnov-g and
busunkim96
google-cla
bot
added
the
cla: yes
software-dov
force-pushed
the
common-resources
branch
5 times, most recently
from
3580ff7
to
9e2285a
Compare
Google Cloud defines a small set of common resources that do not belong to specific APIs or message types. All generated service clients now contain helper methods that allow construction and parsing of these paths. See https://github.com/googleapis/googleapis/blob/master/google/cloud/common_resources.proto for the list of common resources for Google Cloud.
software-dov
force-pushed
the
common-resources
branch
from
9e2285a
to
d5d1340
Compare
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1525 1537 +12
Branches 309 310 +1
=========================================
+ Hits 1525 1537 +12
Continue to review full report at Codecov.
|
arithmetic1728
approved these changes
Sep 29, 2020
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Cloud defines a small set of common resources that do not
belong to specific APIs or message types. All generated service
clients now contain helper methods that allow construction and parsing of these paths.
See
https://github.com/googleapis/googleapis/blob/master/google/cloud/common_resources.proto
for the list of common resources for Google Cloud.