fix: resource messages in method response types generate helpers #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some resource messages are only referenced in method responses, either directly (the method returns a resource) or indirectly (the resource is a field for some other message). These response-resources now generate helper methods in client classes. Contains a minor formatting fix in the generated output, a minor fix in an error message, and a tweak to nox.py to aid interactive debugging.
software-dov
requested review from
lukesneeringer,
crwilcox,
busunkim96 and
arithmetic1728
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1537 1537
Branches 310 310
=========================================
Hits 1537 1537
Continue to review full report at Codecov.
|
arithmetic1728
approved these changes
Sep 30, 2020
busunkim96
approved these changes
Sep 30, 2020
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some resource messages are only referenced in method responses, either
directly (the method returns a resource) or indirectly (the resource
is a field for some other message).
These response-resources now generate helper methods in client
classes.
Contains a minor formatting fix in the generated output, a minor fix
in an error message, and a tweak to nox.py to aid interactive debugging.
Closes #624