fix: fix types on server and bidi streaming callables #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #641 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1538 1538
Branches 310 310
=========================================
Hits 1538 1538 Continue to review full report at Codecov.
|
lidizheng
approved these changes
Oct 8, 2020
There was a problem hiding this comment.
This PR fixes a type annotation error I made. For bidi streaming calls, the asyncio application needs to explicitly invoke await to obtain the AsyncIterable responses (see example). This await is used to establish connection to peer, so the retry can happen immediately instead of being postponed till the first message read. LGTM.
software-dov
approved these changes
Oct 8, 2020
software-dov
changed the title
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return type is an Awaitable that produces an AsyncIterator.