fix: modules referenced in MapField message type are properly aliased #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was noticed when attempting to generate Bigtable Admin in a message definition: an imported module is given an alias to prevent collision with a field name. When the module is referenced to describe the type of a singleton field it is properly disambiguated. When used to describe the type of a MapField it is _not_ disambiguated. Fix for that. Closes googleapis#618
software-dov
requested review from
lukesneeringer,
crwilcox,
vchudnov-g,
busunkim96 and
arithmetic1728
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1562 1563 +1
Branches 316 316
=========================================
+ Hits 1562 1563 +1
Continue to review full report at Codecov.
|
busunkim96
reviewed
Oct 13, 2020
busunkim96
approved these changes
Oct 13, 2020
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was noticed when attempting to generate Bigtable Admin in a
message definition: an imported module is given an alias to prevent
collision with a field name. When the module is referenced to describe
the type of a singleton field it is properly disambiguated. When used
to describe the type of a MapField it is not disambiguated.
Fix for that.
Closes #618