Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile a real proto from googleapis/googleapis during tests. #904

Closed
SurferJeffAtGoogle opened this issue May 21, 2021 · 2 comments
Closed
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@SurferJeffAtGoogle
Copy link

We've seen a few bugs like b/187988047. Even though tests passed, the code generated by the microgenerator failed to compile. This caused dozens of pull requests with tests failing to be opened in python library repositories.

Please add a test that uses real protos from googleapis/googleapis, and runs black, mypy, and flake8 on the output to confirm it compiles. Using a real API is more likely to catch a generator that generates broken code.

CC @busunkim96 @parthea @vam-google

@SurferJeffAtGoogle SurferJeffAtGoogle added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 21, 2021
@software-dov
Copy link
Contributor

I think it's definitely desirable to compile all APIs on CI internally. I'm not sure about picking one API as a smoke test; all APIs have been problem children at some point, and picking any one is going to necessarily be arbitrary.
The problem is that we have two parallel, loosely coupled CI and dev systems. It seems likely that any robust solution to bugs like b/187988047 is going to require strengthening the bond between the two systems.

@software-dov
Copy link
Contributor

Golden tests added by #905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants