Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporarily disable code coverage in showcase_unit tests #925

Merged
merged 6 commits into from
Jun 21, 2021

Conversation

software-dov
Copy link
Contributor

Also updates version of showcase used

@software-dov software-dov requested review from a team as code owners June 18, 2021 21:07
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2021
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #925 (2c41240) into master (7c185e8) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 2c41240 differs from pull request most recent head c07e802. Consider uploading reports for the commit c07e802 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master      #925   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        27    +1     
  Lines         1608      1703   +95     
  Branches       328       347   +19     
=========================================
+ Hits          1608      1703   +95     
Impacted Files Coverage Δ
gapic/samplegen_utils/types.py 100.00% <ø> (ø)
gapic/samplegen_utils/utils.py 100.00% <ø> (ø)
gapic/utils/case.py 100.00% <ø> (ø)
gapic/utils/reserved_names.py 100.00% <ø> (ø)
gapic/generator/generator.py 100.00% <100.00%> (ø)
gapic/samplegen/samplegen.py 100.00% <100.00%> (ø)
gapic/schema/api.py 100.00% <100.00%> (ø)
gapic/schema/metadata.py 100.00% <100.00%> (ø)
gapic/schema/wrappers.py 100.00% <100.00%> (ø)
gapic/utils/__init__.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da119c7...c07e802. Read the comment docs.

cd /usr/src/showcase/
tar -xf showcase-*
./gapic-showcase run &
cd -
env:
SHOWCASE_VERSION: 0.11.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 0.16.0 too? Below as well.

Or I can do it when I rebase the pending #918

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a deliberate attempted rollback to see if bumping the showcase version solved anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants