Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change dynamic routing header field to camelCase #1091

Merged
merged 4 commits into from
Jan 24, 2022
Merged

fix: change dynamic routing header field to camelCase #1091

merged 4 commits into from
Jan 24, 2022

Conversation

alicejli
Copy link
Contributor

Fix for Issue #1090

  1. Fixed issue where the routing annotation request field was not being converted into camelCase (thus causing issues as Javascript converts all the fields to camelCase)
  2. Added more unit tests to cover above use case + nested field case

@alicejli alicejli marked this pull request as ready for review January 22, 2022 00:24
@alicejli alicejli requested a review from a team as a code owner January 22, 2022 00:24
summer-ji-eng
summer-ji-eng approved these changes Jan 22, 2022
View reviewed changes
Copy link
Collaborator

@summer-ji-eng summer-ji-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, with details comment for readability and simplicity. Feel free to merge the PR after address the comments.

Thank you for your promptly fix. 👍

templates/typescript_gapic/_util.njk Outdated Show resolved Hide resolved
typescript/test/unit/proto.ts Show resolved Hide resolved
@alicejli alicejli merged commit 1e05e76 into googleapis:main Jan 24, 2022
@alicejli alicejli deleted the fixRequestParam branch January 24, 2022 18:42
@release-please release-please bot mentioned this pull request Jan 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@summer-ji-eng summer-ji-eng summer-ji-eng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alicejli @summer-ji-eng