fix: close client with stream methodshould return stream object #1101
Conversation
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
|
Investigate if we need a unit test on this case. |
|
Bidi stream and client stream return different error from grpc like: Added server stream unit test for closed client. Will investigate bidi and client later. @alexander-fenster please help me take a look. 🙇 |
| stream.emit('error', new GoogleError('The client has already been closed.')); | ||
| }); | ||
| return stream; | ||
| } |
There was a problem hiding this comment.
doesn't this need to also happen in the rejection arm? ie if the bigQueryStorageStub is rejected (ie. no creds), the the promise will still get bubbled up to streaming.js
There was a problem hiding this comment.
If the bigQueryStorageStub is rejected, it throw an error(see line 225 below). This wouldn't get bubble up to streaming.js.
In other words, only whenbigQueryStorageStub resolved, and client was terminated, the streaming call would receive Passthrough stream with error event.
Make sense. I will release the version, but not going to update the google 3 WORKSPACE yet. |
summer-ji-eng
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
🤖 I have created a release *beep* *boop* --- ## [2.13.0](v2.12.2...v2.13.0) (2022-02-03) ### Features * add snippet metadata file ([#1084](#1084)) ([5965e9c](5965e9c)) ### Bug Fixes * close client with stream methodshould return stream object ([#1101](#1101)) ([40f23d1](40f23d1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Problem: client library always return a rejected promise if the client has been closed. However, when stream make an apicall, it expect a stream object not promise object. This cause
TypeErrorof.onis not function.Fix: return a stream with error event if ongoing stream make on closed client.