fix: rename path template params which is reserved word in strict mode #1124
Conversation
summer-ji-eng
force-pushed
the
fix_strict_mode_reserve_words
branch
from
7f43761
to
d4c5bc4
Compare
| @@ -20,6 +20,19 @@ | |||
| * the template engine. | |||
| */ | |||
|
|
|||
| const STRICT_MODE_RESERVED_WORDS = new Set([ | |||
There was a problem hiding this comment.
Did we recently turn on strict mode, or did we just happen to have not bumped into this issue before?
There was a problem hiding this comment.
As I know, we always use strict mode. The protos are newly added proto.
|
Here is the summary of possible violations 😱 There is a possible violation for not having product prefix.
The end of the violation section. All the stuff below is FYI purposes only. Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
| projectExportPath(project:string,exportParam:string) { | ||
| return this.pathTemplates.projectExportPathTemplate.render({ | ||
| project: project, | ||
| exportParam: exportParam, |
There was a problem hiding this comment.
I believe it should say "export": exportParam here, otherwise it won't get rendered properly. You can do "export" with quotes, gts will remove the quotes if they are not needed.
There was a problem hiding this comment.
Cool. After couple tries with gax and even created a useless PR in gax😢, finally, I got the idea. I only need to update the identifier in the method parameter. Update the PR and please take another look. Thanks for bearing with me. 🤝
nodejs-security-centerusesexportkeyword, preventing compilenodejs-artifact-registryusespackagekeyword preventing compile.TS complains the key words error(see below) when the generator uild a list of resources referenced by this service. We rename the these key words in the strict mode reserved words: