fix: use optional chaining for routing parameters #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
reviewed
May 21, 2022
| @@ -266,8 +266,8 @@ request.{{ oneComment.paramName.toCamelCase() }} | |||
| let routingParameter = {}; | |||
| {%- for paramArray in method.dynamicRoutingRequestParams %} | |||
| {%- for param in paramArray %} | |||
| if((typeof request.{{ param.fieldRetrieve }} !== "undefined") && RegExp('{{ param.messageRegex | safe }}').test(request.{{ param.fieldRetrieve }}!)){ | |||
| Object.assign(routingParameter, { {{ param.fieldSend }}: request.{{ param.fieldRetrieve }}!.match(RegExp('{{ param.namedSegment | safe }}'))![0]})} | |||
| if ((typeof request.{{ param.fieldRetrieve.join('?.') }} !== "undefined") && RegExp('{{ param.messageRegex | safe }}').test(request.{{ param.fieldRetrieve.join('?.') }}!)){ | |||
There was a problem hiding this comment.
So, the old behavior we just had the object access baked into the string, and now we actually use an array type?
Seems like a good refactor to me.
There was a problem hiding this comment.
Yes, the generator keeps the parts as an array, and we only merge them with ?. in the template.
bcoe
approved these changes
May 21, 2022
summer-ji-eng
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1137. The generated code for routing headers should use optional chaining (
?.) instead of just dots for nested field names. Currently, it breaks compilation for Cloud Run v2 client library.The change includes a small refactor: it's not correct to concatenate a dot-separated name in the generator code because, by design, the generator has no knowledge of the target language. All language specific stuff must be limited to the templates. So now the generator will only keep the list of camelCased field names, that will be joined (with
?.) in the template.