fix: camel case for multiple capital letters #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of possible violations 😱 There is a possible violation for not having product prefix.
The end of the violation section. All the stuff below is FYI purposes only. Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
| @@ -240,7 +240,7 @@ export class NamingClient { | |||
| // Iterate over each of the methods that the service provides | |||
| // and create an API call method for each. | |||
| const namingStubMethods = | |||
| ['paginatedMethod', 'paginatedMethodStream', 'paginatedMethodAsync', 'longRunning', 'checkLongRunningProgress', 'initialize', 'servicePath', 'apiEndpoint', 'port', 'scopes', 'getProjectId', 'getReservedWord']; | |||
| ['paginatedMethod', 'paginatedMethodStream', 'paginatedMethodAsync', 'longRunning', 'checkLongRunningProgress', 'initialize', 'servicePath', 'apiEndpoint', 'port', 'scopes', 'getProjectId', 'getReservedWord', 'createAbcdeSomething']; | |||
There was a problem hiding this comment.
Here is the main change: if you scroll to the right, the last element of this list is createAbcdeSomething. It would've been createABCDESomething without the fix.
sofisl
approved these changes
Jun 17, 2022
alexander-fenster
added a commit
that referenced
this pull request
Jun 30, 2022
alexander-fenster
added a commit
that referenced
this pull request
Jul 1, 2022
* fix: follow case convention #1149 in generated tests * fix: one more place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1148, googleapis/nodejs-os-config#173.
protobuf.jsand@grpc/grpc-jsuse somewhat different logic when camel-casing strings likeCreateOSPolicy, where multiple capital letters form a word. In our current code, it will be camel-cased ascreateOSPolicy, while these libraries expectcreateOsPolicy.Implementing a special mode to use internally for this specific case. External interfaces of the generated libraries should not be affected in any way.