Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloud run API: linting error in the generated code #1154

Closed
alexander-fenster opened this issue Jun 30, 2022 · 0 comments · Fixed by #1160
Closed

cloud run API: linting error in the generated code #1154

alexander-fenster opened this issue Jun 30, 2022 · 0 comments · Fixed by #1160
Assignees
@alexander-fenster
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@alexander-fenster
Copy link
Contributor

image

src/v2/services_client.ts#L1035
Optional chain expressions can return undefined by design - using a non-null assertion is unsafe and wrong
@alexander-fenster alexander-fenster added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 30, 2022
@alexander-fenster alexander-fenster mentioned this issue Jun 30, 2022
Merged
1 task
@alexander-fenster alexander-fenster self-assigned this Jun 30, 2022
@alexander-fenster alexander-fenster added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 30, 2022
@alexander-fenster alexander-fenster mentioned this issue Jul 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexander-fenster alexander-fenster

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: proper processing of routing headers googleapis/gapic-generator-typescript
1 participant
@alexander-fenster