Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use _gaxModule when accessing gax for bundling #1232

Merged
merged 6 commits into from
Aug 30, 2022
Merged

fix: use _gaxModule when accessing gax for bundling #1232

merged 6 commits into from
Aug 30, 2022

Conversation

alexander-fenster
Copy link
Contributor

We now import google-gax as import type, so we must use an instance when accessing its functions.

Also, add nodejs-logging library to the test executed in CI to make sure it actually compiles.

@alexander-fenster alexander-fenster requested a review from a team as a code owner August 29, 2022 23:09
@snippet-bot
Copy link

snippet-bot bot commented Aug 30, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 12 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@alexander-fenster alexander-fenster merged commit 2e8611a into main Aug 30, 2022
@alexander-fenster alexander-fenster deleted the gax-bundling branch August 30, 2022 01:20
@release-please release-please bot mentioned this pull request Aug 30, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 30, 2022
@release-please
chore(main): release 2.16.1 (#1229)
bcb39d3 
🤖 I have created a release *beep* *boop*
---


## [2.16.1](v2.16.0...v2.16.1) (2022-08-30)


### Bug Fixes

* **deps:** update dependency google-gax to ^3.3.1 ([#1234](#1234)) ([9900e88](9900e88))
* **deps:** update dependency protobufjs to ^7.1.0 ([#1228](#1228)) ([0066ceb](0066ceb))
* use _gaxModule when accessing gax for bundling ([#1232](#1232)) ([2e8611a](2e8611a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losalex losalex losalex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-fenster @losalex