fix: preserve default values in x-goog-request-params (#1250) #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-fenster
force-pushed
the
update-showcase-baseline
branch
from
2f23bd8
to
939b61a
Compare
|
Here is the summary of possible violations 😱 There are 2 possible violations for not having product prefix.
The end of the violation section. All the stuff below is FYI purposes only. Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
1 similar comment
|
Here is the summary of possible violations 😱 There are 2 possible violations for not having product prefix.
The end of the violation section. All the stuff below is FYI purposes only. Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
noahdietz
approved these changes
Sep 8, 2022
* fix: preserve default values in x-goog-request-params header * test: updated baselines for compliance * fix: do not change logic for legacy proto load * test: generate simpler test for routing headers * fix: make unit tests actually check headers
alexander-fenster
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the compliance baseline does not actually compile. I will fix it in a separate PR against this branch, otherwise, the fixes will be really hard to review.
Upd. The PR that fixes things here is #1250.