feat: option to request REST numeric enum values #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-fenster
force-pushed
the
numeric-enums
branch
from
6118474
to
86a5133
Compare
vchudnov-g
reviewed
Sep 8, 2022
| @@ -157,6 +157,11 @@ export class {{ service.name }}Client { | |||
| const fallback = opts?.fallback ?? (typeof window !== 'undefined' && typeof window?.fetch === 'function'); | |||
| opts = Object.assign({servicePath, port, clientConfig, fallback}, opts); | |||
| {%- endif %} | |||
| {%- if api.restNumericEnums %} | |||
There was a problem hiding this comment.
Is this inside something like if rest so it only gets applied when we generate REST transport?
There was a problem hiding this comment.
As discussed - we generate almost the same code for REST and gRPC client (the only difference being the default transport), so we want to pass this option down to gax even if the client is generated as a gRPC one, because the customer might choose to use it as a REST client by passing {fallback: 'rest'} to the constructor.
vchudnov-g
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing an option to turn on numeric enums for REST transport down the stack.