feat!: convert to ESM, use Aspect build rules #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-fenster
force-pushed
the
aspect
branch
7 times, most recently
from
f5ed199
to
d7c021f
Compare
alexander-fenster
force-pushed
the
aspect
branch
from
d7c021f
to
a41dad5
Compare
|
@ddelgrosso1 FYI - Ben suggested I add you for the ESM conversion commit (just this one). This is our GAPIC generator and it's going to be an ESM app from now on. The fact that it's built by Bazel greatly complicates things. |
alexander-fenster
force-pushed
the
aspect
branch
from
a41dad5
to
ce55a94
Compare
bcoe
suggested changes
Feb 2, 2023
sofisl
reviewed
Feb 2, 2023
| if (name.service === serviceName && name.method === methodName) { | ||
| exactMatch = config; | ||
| for (const name of config.name) { | ||
| if (name.service === serviceName && !name.method) { |
There was a problem hiding this comment.
Seems kind of strange to me that this wouldn't be an if/else, because would it be possible for !name.method and name.method ==== methodName?
There was a problem hiding this comment.
Agreed, if-else is more logical here. Fixed.
sofisl
approved these changes
Feb 3, 2023
bcoe
approved these changes
Feb 3, 2023
This was referenced Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of four commits that are logically unrelated but should go together. It might be easier to review them one by one.
Update baselines (copyright year and minor changes of dependency protos). This one is straightforward.
Change the Bazel stack to use the new Aspect rules for JavaScript and TypeScript. Unfortunately, for TypeScript, I'm currently using my fork of the rules that fixes some issues; I'll try to contribute it upstream but I'm willing to use the fork while this is in progress to unblock this repository.
Make the generator an ESM module. It simplifies working with new dependencies, and make TypeScript emit more predictable code (compared with the one with commonjs requires).
Remove fragile parts that keep breaking. We are getting rid of
gtsandeslint(for now, until they properly support the new ESM import syntax - I filed bring back gts and/or eslint #1308) and also getting rid of complicated integration tests: they were broken anyway but were reporting pass, which is the worst thing a test can do. I'll need to rethink how to make good integration tests. For now, we still have baseline test and we check that the generated libraries compile properly.R= @noahdietz for Bazel related fixes (this commit specifically)
R= @sofisl and @bcoe for ESM related fixes (this commit)