Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not generate docs-test script #1391

Merged
merged 2 commits into from
Jun 1, 2023
Merged

fix: do not generate docs-test script #1391

merged 2 commits into from
Jun 1, 2023

Conversation

alexander-fenster
Copy link
Contributor

Since we stopped running docs-test script as a part of our CI in google-cloud-node, let's stop pulling linkinator as a dev dependency, and stop adding the docs-test script for the new libraries.

This change will only affect newly generated libraries.

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I would like us to figure out another place where we can catch broken links.

Early bird?

@alexander-fenster alexander-fenster added the automerge Merge the pull request once unit tests and other checks pass. label Jun 1, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit fe5af77 into main Jun 1, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the no-link branch June 1, 2023 16:54
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 1, 2023
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants