fix!: correct IAM return types #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feywind
added
kokoro:force-run
sofisl
approved these changes
Jul 18, 2023
sofisl
pushed a commit
that referenced
this pull request
Sep 2, 2023
* fix: correct IAM return types * tests: update baseline * build: remove kms test until it can be updated for gax
sofisl
pushed a commit
that referenced
this pull request
Sep 2, 2023
* fix: correct IAM return types * tests: update baseline * build: remove kms test until it can be updated for gax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return types for these calls should be tuples, not singletons.
Related: googleapis/gax-nodejs#1001