Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support GOOGLE_CLOUD_UNIVERSE_DOMAIN environment variable #1558

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

alexander-fenster
Copy link
Contributor

@alexander-fenster alexander-fenster commented Mar 14, 2024

According to the spec, this environment variable points to the universe if it's not configured in the code. If it's set in the code, the value from the code has priority.

@alexander-fenster
Copy link
Contributor Author

@sofisl Can you take a look what's going on with the ESM tests?

node_modules/@js-sdsl/ordered-map/dist/esm/index.d.ts:402:35 - error TS2748: Cannot access ambient const enums when 'isolatedModules' is enabled.

402 export type { OrderedMapIterator, IteratorType, Container, ContainerIterator, TreeContainer };
                                      ~~~~~~~~~~~~

Is it caused by some dependency update?

@sofisl
Copy link
Contributor

sofisl commented Mar 15, 2024

Is it caused by some dependency update?

it is caused by the @js-sdl dep being added to grpc: https://github.com/grpc/grpc-node/pull/2677/files

We can just turn off isolatedModules flag, it won't affect the generated code and, since it's in CJS, none of our other libraries use it.

@alexander-fenster alexander-fenster merged commit 884b02e into main Mar 21, 2024
27 checks passed
@alexander-fenster alexander-fenster deleted the tpc-env-var branch March 21, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants