Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Java gapics: Use ResourceName types for singular params in flattened methods #2137

Closed
andreamlin opened this issue Jul 3, 2018 · 1 comment
Closed

Java gapics: Use ResourceName types for singular params in flattened methods #2137

andreamlin opened this issue Jul 3, 2018 · 1 comment
Assignees
@yihanzhen
Labels
lang: java Issues specific to Java. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@andreamlin
Copy link
Contributor

#2131 introduces a change to prevent all flattened methods that have at least one repeated param from using ResourceName types (uses String instead).

Improve client usability by allowing singular params to be ResourceName types, even when the repeated params are using List types.
@andreamlin andreamlin added priority: p2 Moderately-important priority. Fix may not be included in next release. lang: java Issues specific to Java. labels Jul 3, 2018
@andreamlin andreamlin mentioned this issue Jul 3, 2018
Merged
@vchudnov-g vchudnov-g added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Nov 7, 2018
@andreamlin andreamlin assigned yihanzhen and unassigned andreamlin Jun 14, 2019
@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Jun 27, 2019
@sduskis sduskis removed 🚨 This issue needs some love. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 3, 2019
@yihanzhen
Copy link
Contributor

Fixed in #3081

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yihanzhen yihanzhen

Labels
lang: java Issues specific to Java. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sduskis @JustinBeckwith @andreamlin @vchudnov-g @yihanzhen