Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: reduce module size by remove duplicate storage for protos files #1249

Merged
merged 8 commits into from
May 5, 2022

Conversation

summer-ji-eng
Copy link
Contributor

@summer-ji-eng summer-ji-eng commented May 4, 2022

Significantly reduce the module size

-- before after
package size 869.6 kB 575.4KB
unpacked size 10.9 MB 5. MB

This is a BREAKING_CHANGE!
A client library refer to protos/.. file should throw error with gax updates. To fix it, we should refer to build/protos/.. instead.

@summer-ji-eng summer-ji-eng requested a review from a team as a code owner May 4, 2022 07:36
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 4, 2022
@summer-ji-eng summer-ji-eng added the automerge Merge the pull request once unit tests and other checks pass. label May 5, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4d2a04d into main May 5, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the dedupe_protos branch May 5, 2022 23:46
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants