fix: revert gRPC stream change in #1226 #1257

summer-ji-eng · 2022-05-06T19:03:06Z

Moving out lines from the retryStream cause failing to emit the closed client error.

const stream = apiCall(argument, this._callback) as CancellableStream;
this.stream = stream

summer-ji-eng added 2 commits May 6, 2022 11:58

fix: revert gRPC stream change in #1226

9ea8555

fix linter

85aa067

summer-ji-eng requested a review from a team as a code owner May 6, 2022 19:03

product-auto-label bot added the size: s Pull request size is small. label May 6, 2022

summer-ji-eng requested a review from alexander-fenster May 6, 2022 19:03

alexander-fenster approved these changes May 6, 2022

View reviewed changes

add showcase integration test

ceafae5

summer-ji-eng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2022

add unit test

565a878

summer-ji-eng merged commit 1c3a5a7 into main May 9, 2022

summer-ji-eng deleted the stream_close branch May 9, 2022 17:33

release-please bot mentioned this pull request May 9, 2022

chore(main): release 3.0.0 #1261

Merged

summer-ji-eng added a commit that referenced this pull request May 9, 2022

fix: revert gRPC stream change in #1226 (#1257)

ed0844e

Provide feedback