Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle fetch errors #1294

Merged
merged 1 commit into from
Jul 18, 2022
Merged

fix: handle fetch errors #1294

merged 1 commit into from
Jul 18, 2022

Conversation

milesnash
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1292

@milesnash milesnash requested a review from a team as a code owner July 14, 2022 20:15
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 14, 2022
@alexander-fenster alexander-fenster added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 15, 2022
@sofisl
Copy link
Contributor

sofisl commented Jul 15, 2022

Hi @milesnash, can you provide an issue to understand what this fix is for? Thank you!

@milesnash
Copy link
Contributor Author

Hi @milesnash, can you provide an issue to understand what this fix is for? Thank you!

No worries, you're welcome! I mentioned it in the description, it's issue #1292

@alexander-fenster alexander-fenster added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 18, 2022
@alexander-fenster alexander-fenster merged commit 39b06dd into googleapis:main Jul 18, 2022
@alexander-fenster
Copy link
Contributor

Thank you @milesnash! I'll release this later this week.

@release-please release-please bot mentioned this pull request Jul 18, 2022
Merged
@milesnash
Copy link
Contributor Author

Thank you @milesnash! I'll release this later this week.

Great! You're welcome, my pleasure 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught exception when fetch API rejects
4 participants
@milesnash @sofisl @alexander-fenster @yoshi-kokoro