Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update required version as new features are used from it #1559

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

Rochet2
Copy link
Contributor

@Rochet2 Rochet2 commented Feb 7, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1557 🦕

@Rochet2 Rochet2 requested review from a team as code owners February 7, 2024 20:46
Copy link

google-cla bot commented Feb 7, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Feb 7, 2024
Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexander-fenster alexander-fenster changed the title Update required version as new features are used from it fix(deps): update required version as new features are used from it Feb 7, 2024
Copy link

conventional-commit-lint-gcf bot commented Feb 7, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@alexander-fenster
Copy link
Contributor

alexander-fenster commented Feb 7, 2024

@Rochet2 would you mind signing the CLA please?

@alexander-fenster alexander-fenster added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 7, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 7, 2024
@Rochet2
Copy link
Contributor Author

Rochet2 commented Feb 7, 2024

@alexander-fenster Done

@alexander-fenster alexander-fenster added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2024
@alexander-fenster alexander-fenster added automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 8, 2024
@alexander-fenster alexander-fenster removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Feb 8, 2024
@alexander-fenster alexander-fenster merged commit 81978ac into googleapis:main Feb 8, 2024
17 of 18 checks passed
This was referenced Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library fails with "this.auth.getUniverseDomain is not a function"
3 participants