Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expose underlying error with timeouts or retries #1650

Merged
merged 5 commits into from
Sep 4, 2024
Merged

fix: expose underlying error with timeouts or retries #1650

merged 5 commits into from
Sep 4, 2024

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Aug 30, 2024

Fixes #1643

@sofisl sofisl requested review from a team as code owners August 30, 2024 20:47
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 30, 2024
leahecole
leahecole approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for test application! Looks great @sofisl !

@leahecole leahecole merged commit f4d037a into main Sep 4, 2024
21 checks passed
@leahecole leahecole deleted the exposeErrorDuringTimeout branch September 4, 2024 15:20
@release-please release-please bot mentioned this pull request Sep 4, 2024
Merged
@leahecole leahecole mentioned this pull request Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Underlying error causing timeout not properly surfaced in normal/unary call retries
2 participants
@sofisl @leahecole