Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CredentialsWrapper doesn't use authCache when building ApplicationDefaultCredentials #372

Open
peetya opened this issue Jan 27, 2022 · 1 comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@peetya
Copy link

peetya commented Jan 27, 2022

Is your feature request related to a problem? Please describe.
I am connecting to different GCP services from GKE using PHP and I am struggling to configure cache for the credentials fetcher in BigtableClient. I defined my cache implementation in BigtableClient through $config['credentialsConfig']['authCache']. As I am not using key files, the CredentialsWrapper will build the ApplicationDefaultCredentials, but instead of using the received parameters, the authCache and the authCacheOptions are hardcoded null values: https://github.com/googleapis/gax-php/blob/main/src/CredentialsWrapper.php#L129-L130

Describe the solution you'd like
I expect these parameters to be used in buildApplicationDefaultCredentials method instead of using null values.

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jan 28, 2022
@vam-google vam-google added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 31, 2022
@vam-google
Copy link
Contributor

@bshaffer @noahdietz This looks like something which can be relatively easily fixed, can you please take a quick look?

@vam-google vam-google removed the triage me I really want to be triaged. label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants