Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add strict types to all class files #435

Open
bshaffer opened this issue Dec 21, 2022 · 0 comments
Open

feat: add strict types to all class files #435

bshaffer opened this issue Dec 21, 2022 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bshaffer
Copy link
Contributor

Static analysis takes care of this for the most part, but it'd still be good to use strict_types in all our classes, now that this library is for PHP 7.0+

declare(strict_types=1);

See https://dev.to/rocksheep/the-way-stricttypes-works-in-php-eb7
@bshaffer bshaffer added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jan 27, 2023
@yash30201 yash30201 added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bshaffer @yash30201