Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Extend GCP Residency Detection Support #528

Merged
merged 13 commits into from
Dec 7, 2022
Merged

feat: Extend GCP Residency Detection Support #528

merged 13 commits into from
Dec 7, 2022

Conversation

danielbankhead
Copy link
Contributor

Extends GCP Residency Detection Support in order to improve timeout logic for metadata checking.

Resolves downstream issue: googleapis/google-auth-library-nodejs#1236

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 16, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Aug 17, 2022
@danielbankhead danielbankhead marked this pull request as ready for review August 17, 2022 00:37
@danielbankhead danielbankhead requested a review from a team as a code owner August 17, 2022 00:37
@danielbankhead
Copy link
Contributor Author

Writing tests for this is a bit complicated; attempted to use sinon to mock fs and child_process calls, but with no luck.

However: here's proof the Windows regex/logic is working as expected:

@danielbankhead danielbankhead requested a review from bcoe August 17, 2022 00:47
@danielbankhead danielbankhead added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2022
ruyadorno
ruyadorno reviewed Aug 17, 2022
View reviewed changes
Copy link

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few ideas on possible improvements but otherwise it LGTM 👍

src/gcp-residency.ts Outdated Show resolved Hide resolved
src/gcp-residency.ts Outdated Show resolved Hide resolved
test/gcp-residency.test.ts Outdated Show resolved Hide resolved
@danielbankhead danielbankhead added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 23, 2022
@danielbankhead danielbankhead changed the title feat: Extend GCP Residency Detection Support feat: Extend GCP Residency Detection Support for Linux Aug 25, 2022
@danielbankhead danielbankhead changed the title feat: Extend GCP Residency Detection Support for Linux feat: Extend GCP Residency Detection Support Sep 1, 2022
@danielbankhead
Copy link
Contributor Author

do no merge: Awaiting internal strategy approval for using MAC Address

@danielbankhead danielbankhead mentioned this pull request Oct 25, 2022
Closed
@d-goog
feat: Extend GCP Serverless Runtime Support
7bdf868 
- A refactor + Cloud Run Job support
@danielbankhead danielbankhead removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 6, 2022
TimurSadykov
TimurSadykov approved these changes Dec 7, 2022
View reviewed changes
Copy link

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielbankhead danielbankhead merged commit 2b35bb0 into main Dec 7, 2022
@danielbankhead danielbankhead deleted the improve-adc-detection branch December 7, 2022 23:04
@release-please release-please bot mentioned this pull request Dec 7, 2022
Merged
@theneva theneva mentioned this pull request Dec 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimurSadykov TimurSadykov TimurSadykov approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

@bcoe bcoe Awaiting requested review from bcoe

Assignees
No one assigned
Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielbankhead @ruyadorno @TimurSadykov @d-goog