Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove @babel/plugin-proposal-private-methods #563

Closed
danielbankhead opened this issue Jun 28, 2023 · 1 comment · Fixed by #573
Closed

refactor: Remove @babel/plugin-proposal-private-methods #563

danielbankhead opened this issue Jun 28, 2023 · 1 comment · Fixed by #573
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@danielbankhead
Copy link
Contributor

Context: #562 (comment)
@danielbankhead danielbankhead added priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern. next major: breaking change this is a change that we should wait to bundle into the next major version semver: major Hint for users that this is an API breaking change. labels Jun 28, 2023
@danielbankhead danielbankhead changed the title Refactor!: Remove @babel/plugin-proposal-private-methods refactor!: Remove @babel/plugin-proposal-private-methods Jun 28, 2023
@danielbankhead danielbankhead mentioned this issue Jun 28, 2023
Merged
@danielbankhead danielbankhead linked a pull request Jul 17, 2023 that will close this issue
chore: remove @babel/plugin-proposal-private-methods #573
Merged
@danielbankhead danielbankhead mentioned this issue Jul 17, 2023
Merged
@danielbankhead
Copy link
Contributor Author

Looks like it's blocked by an upstream bug compodoc/compodoc#1361.

However, the change shouldn't be considered breaking anymore since we're on Node 14 now (which supports the private fields that compodoc is complaining about).

Also, we should consider moving off of compodoc entirely to something that more well maintained.

@sofisl sofisl removed the next major: breaking change this is a change that we should wait to bundle into the next major version label Jul 18, 2023
@danielbankhead danielbankhead removed the semver: major Hint for users that this is an API breaking change. label Jul 18, 2023
@danielbankhead danielbankhead changed the title refactor!: Remove @babel/plugin-proposal-private-methods refactor: Remove @babel/plugin-proposal-private-methods Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove @babel/plugin-proposal-private-methods googleapis/gcp-metadata
2 participants
@danielbankhead @sofisl