Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support positional parameters #18

Closed
olavloite opened this issue Jul 28, 2021 · 0 comments · Fixed by #110
Closed

Support positional parameters #18

olavloite opened this issue Jul 28, 2021 · 0 comments · Fixed by #110
Assignees
@rahul2393
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@olavloite
Copy link
Collaborator

Cloud Spanner expects parameters to be supplied as named parameters in the format @name. Many examples and frameworks use ? as a parameter placeholder. As the go-sql-spanner driver is parsing the sql strings in search for parameters anyways, the driver could also easily support positional parameters in addition to named parameters, by automatically renaming the positional parameters into named parameters.
@codyoss codyoss added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jan 18, 2022
@rahul2393 rahul2393 self-assigned this Aug 9, 2022
@rahul2393 rahul2393 mentioned this issue Aug 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul2393 rahul2393

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support of positional parameter in the queries googleapis/go-sql-spanner
3 participants
@olavloite @codyoss @rahul2393