fix: Do not panic when nil is passed in as a query parameter to a pointer of type that implements driver.Valuer via a value receiver #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nter of type that implements driver.Valuer via a value receiver Pass nil to the database when a nil pointer to a type that implements driver.Valuer via a value receiver; this follows the behavior of database/sql
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
olavloite
approved these changes
Sep 30, 2024
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
🤖 I have created a release *beep* *boop* --- ## [1.7.2](https://togithub.com/googleapis/go-sql-spanner/compare/v1.7.1...v1.7.2) (2024-09-30) ### Bug Fixes * Do not panic when nil is passed in as a query parameter to a pointer of type that implements driver.Valuer via a value receiver ([#296](https://togithub.com/googleapis/go-sql-spanner/issues/296)) ([816847b](https://togithub.com/googleapis/go-sql-spanner/commit/816847b09031a272af228350448d774d97ee6d7b)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass nil to the database when a nil pointer to a type that implements driver.Valuer via a value receiver; this follows the behavior of database/sql
Fixes #295