Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inappropriate HttpClient set up for resumable downloads #929

Closed
jskeet opened this issue Mar 14, 2017 · 2 comments
Closed

Inappropriate HttpClient set up for resumable downloads #929

jskeet opened this issue Mar 14, 2017 · 2 comments
Assignees
@jskeet

Comments

@jskeet
Copy link
Collaborator

jskeet commented Mar 14, 2017 •
edited
Loading

See googleapis/google-cloud-dotnet#824 for details, but basically we should be using HttpClientFactory. (I think it's reasonable to use the default one, given that the caller can always override the HttpClient in the ResumableUploadOptions.)
@jskeet jskeet self-assigned this Mar 14, 2017
@jskeet
Copy link
Collaborator Author

jskeet commented Mar 14, 2017

(I'll create a patch for this shortly.)

@chrisdunelm
Copy link
Contributor

Fixed via #930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jskeet jskeet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jskeet @chrisdunelm