feat(all): prefer using WithDefaultScope option internally #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently these clients don't allow users to specify an aud because both aud and scopes may not be provided at the same time. By moving internal logic to use WithDefaultScopes we allow more flexability with these clients. Updated local cached file. Internal issue: b/223898679
codyoss
added
the
do not merge
|
Doing a couple of spot checks still. |
codyoss
removed
the
do not merge
|
Similar changes have been present in our GAPIC clients for a long time now: googleapis/google-cloud-go#3374 |
noahdietz
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently these clients don't allow users to specify an aud because
both aud and scopes may not be provided at the same time. By moving
internal logic to use WithDefaultScopes we allow more flexability
with these clients. Updated local cached file.
Internal issue: b/223898679