Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(option/internaloption): add new EmbeddableAdapter option #1787

Merged
merged 3 commits into from
Dec 15, 2022

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Dec 15, 2022

No description provided.

@codyoss codyoss requested review from a team and yoshi-approver as code owners December 15, 2022 22:12
@codyoss
Copy link
Member Author

codyoss commented Dec 15, 2022

cc @tritone @BrennaEpp

Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Dec 15, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1569e5b into googleapis:main Dec 15, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 15, 2022
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Belatedly -- looks good to me, thanks for this @codyoss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants