Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): allow Accept-Encoding header #2758

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

BrennaEpp
Copy link
Contributor

@BrennaEpp BrennaEpp commented Aug 27, 2024

Fixes #2757

Code needs to be regenerated to match up with the additional parameters in gensupport.

@BrennaEpp BrennaEpp requested a review from a team as a code owner August 27, 2024 10:48
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Aug 27, 2024
@quartzmo
Copy link
Member

quartzmo commented Sep 4, 2024

kokoro error:

apigee/v1/apigee-gen.go:12017:52: not enough arguments in call to gensupport.SendRequest
	have (context.Context, *"net/http".Client, *"net/http".Request)
	want (context.Context, *"net/http".Client, *"net/http".Request, bool)

@quartzmo
Copy link
Member

quartzmo commented Sep 4, 2024

In order to get a passing Kokoro presubmit check for this PR, you may want to regenerate all of the clients locally and then commit them in your branch, as @codyoss and I usually do. (Recent example in #2670.) You can do it by running make cached in the google-api-go-generator directory. You may also need to run tests locally with the update_golden flag if the golden files are in scope for this change. (See gen_test.go for how that works.)

@BrennaEpp
Copy link
Contributor Author

In order to get a passing Kokoro presubmit check for this PR, you may want to regenerate all of the clients locally and then commit them in your branch, as @codyoss and I usually do. (Recent example in #2670.) You can do it by running make cached in the google-api-go-generator directory. You may also need to run tests locally with the update_golden flag if the golden files are in scope for this change. (See gen_test.go for how that works.)

I updated everything, but am still seeing errors locally (I can't see the kokoro build):

--- FAIL: TestNewClient (0.00s)
    dial_test.go:26: got *oauth2.Transport, want: *httptransport.authTransport
FAIL
FAIL    google.golang.org/api/transport/http    0.347s

This seems unrelated to the changes I made, can you help me fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gensupport/storage: allow Accept-Encoding header
2 participants