fix(core): allow BaseService#root_url to be an Addressable::URI #17895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #17131. Addresses #17894.
BaseService#root_url
is documented as anAddressable::URI
, but inBaseService#root_url=
it is used as if it is aString
. This results in the following error:The tests seem to indicate that
root_url
was always allowed to be aString
and I don't see any code prior to #17131 which required it to be anAddressable::URI
. Therefore I am proposing updating the documentation to indicate that it can be either.