Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle impersonated ADC #1425

Merged
merged 8 commits into from
Jun 30, 2022
Merged

feat: handle impersonated ADC #1425

merged 8 commits into from
Jun 30, 2022

Conversation

cstanger
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

This PR is intent to add the handing of impersonated ADC in the context of the credentials instance creation.

Fixes

@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 27, 2022
@cstanger cstanger changed the title Handle impersonated ADC feat: handle impersonated ADC Jun 27, 2022
@cstanger cstanger marked this pull request as ready for review June 27, 2022 16:05
@cstanger cstanger requested review from a team as code owners June 27, 2022 16:05
danielbankhead
danielbankhead suggested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few items before we're ready to merge.

src/auth/googleauth.ts Outdated Show resolved Hide resolved
src/auth/googleauth.ts Outdated Show resolved Hide resolved
src/auth/impersonated.ts Outdated Show resolved Hide resolved
@danielbankhead danielbankhead added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 30, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2022
@danielbankhead danielbankhead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2022
@danielbankhead danielbankhead merged commit 835be89 into googleapis:main Jun 30, 2022
@release-please release-please bot mentioned this pull request Jun 30, 2022
Merged
This was referenced Jun 30, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cstanger @danielbankhead @yoshi-kokoro