Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce environment variable for quota project #1478

Merged
merged 8 commits into from
Nov 4, 2022
Merged

feat: Introduce environment variable for quota project #1478

merged 8 commits into from
Nov 4, 2022

Conversation

sai-sunder-s
Copy link
Contributor

@sai-sunder-s sai-sunder-s commented Oct 21, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@sai-sunder-s sai-sunder-s requested review from a team as code owners October 21, 2022 23:06
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 21, 2022
alexander-fenster
alexander-fenster approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some comments. Please wait for Daniel's review before submitting.

@danielbankhead danielbankhead self-assigned this Oct 25, 2022
@danielbankhead danielbankhead added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 26, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 26, 2022
danielbankhead
danielbankhead reviewed Oct 26, 2022
View reviewed changes
Copy link
Contributor

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few more things to consider after further review

src/auth/authclient.ts Outdated Show resolved Hide resolved
src/auth/googleauth.ts Outdated Show resolved Hide resolved
src/auth/authclient.ts Outdated Show resolved Hide resolved
danielbankhead
danielbankhead reviewed Nov 4, 2022
View reviewed changes
Copy link
Contributor

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; just need 1 more test.

src/auth/googleauth.ts Outdated Show resolved Hide resolved
test/test.googleauth.ts Show resolved Hide resolved
danielbankhead
danielbankhead approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@danielbankhead danielbankhead added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 4, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 4, 2022
@sai-sunder-s sai-sunder-s merged commit 8706abc into googleapis:main Nov 4, 2022
@release-please release-please bot mentioned this pull request Nov 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees

@danielbankhead danielbankhead

Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sai-sunder-s @alexander-fenster @danielbankhead @d-goog